Allow GSL atmosphere_model to run with NCAR init files #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyasmirnova
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@barlage Mike, I agree with all changes you made in this PR.
|
thanks @tanyasmirnova, I feel like this is one of those things that we need to propose to NCAR as a permanent change since this is just trying to recover capabilities that are already available in WRF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
GSL code will be able to run with NCAR created init files.
When running hrrrv5 suite, the answers are unchanged.
This does not fix all reproducibility issues. See #66