Feat: idsse-368: publish confirm tests #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
IDSSE-368
Changes
Unit tests for PublishConfirm
Quite complicated to read unfortunately, since I ended up building a functioning mock of every
pika
object or method that PublishConfirm useson_connect
callback arg to some pika method, my mock method really does accept this as an argument, and invokes the callback right away.More type hinting for PublishConfirm
Based on pika docs. For example, what args our callback methods expect to be sent by pika
Error handling for publish_message
Raise exception if someone attempts to call
publish_message()
before any channel has been opened.