Start of JSON schema tool kit #6
Conversation
Geary-Layne
requested review from
rabellino-noaa,
paulhamer-noaa and
mackenzie-grimes-noaa
There was a problem hiding this comment.
Glad we have a common method now to create timestamps, it's something that is done a lot in different ways in many places. We will have update some of our services (EPM, ECM, IMS Gateway) to include the commons package as they currently do not
| "Region": { | ||
| "description": "Identifier for a geographic region", | ||
| "type": "string", | ||
| "enum": ["CO", "AK", "PR", "HI"] |
There was a problem hiding this comment.
I assume CO here is CONUS? Is there a use case for this enum where it could be Colorado?
There was a problem hiding this comment.
Yep, CO is for CONUS. Don't expect we will have products that are available by state, but if we do we'll need to make some changes. I think the most likely next step, is products that are custom local domains. Like a super high resolution wind model in the area surrounding a fire. Don't have a solution for that, but we'll deal with it when we need to.
Linear 219
Goal here was to bring the json schema work that I had stared in DAS into common and set it up to be used for the whole system. There is still more work but this should set the framework. See the json-schema.rst (in this pr) for more documentation. There are a number of messages with IDSSe that are not covered here that will need to be added (eventPort, all NewData messages, DAS_web_servcie input, ...), and the Criteria message schema is only partial. I would like to change the Criteria message (and maybe eventPort) to be more similar to the rest.