Bug/idss 305/iso datetime #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geary-Layne
requested review from
rabellino-noaa,
paulhamer-noaa and
mackenzie-grimes-noaa
rabellino-noaa
approved these changes
Aug 14, 2023
paulhamer-noaa
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Linear 305.
utils.py::to_iso(dt: datetime)
The previous implementation was tested against datetime instances created by:
datetime.datetime(...)
datetime.now(timezone.utc)
datetime.utcnow()
When updating test the utilize to_iso() is was discovered that datetime.parser.parse(dt_string) results in a datetime instance the represent the timezone in an alternative way. The new implementation uses a string rep of timezone vs the enum type.