Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed KeyError where 'x-queue-type' was assumed to be in args #83

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fixed KeyError where 'x-queue-type' was assumed to be in args #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f8238
fixed KeyError where 'x-queue-type' was assumed to be in args
Geary-Layne Nov 1, 2024
b4ea48f
removed debug code
Geary-Layne Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/idsse_common/idsse/common/rabbitmq_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ def subscribe_to_queue(

def _setup_exch_and_queue(channel: Channel, exch: Exch, queue: Queue):
"""Setup an exchange and queue and bind them with the queue's route key(s)"""
if queue.arguments['x-queue-type'] == 'quorum' and queue.auto_delete:
if queue.arguments and 'x-queue-type' in queue.arguments and \
queue.arguments['x-queue-type'] == 'quorum' and queue.auto_delete:
raise ValueError('Quorum queues can not be configured to auto delete')

_setup_exch(channel, exch)
Expand Down
Loading