Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added developer workflow #34

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

edwardhartnett
Copy link
Contributor

Part of #33

@edwardhartnett
Copy link
Contributor Author

Repo manager has to turn on CI with GitHub actions.

@edwardhartnett
Copy link
Contributor Author

IIRC the way to turn on GitHub actions is to merge this PR, adding a YML file in the .github/workflows directory...

@christopherwharrop-noaa
Copy link
Collaborator

To clarify, you will submit multiple PRs which will collectively address #33 and this one is just the first one? Here it looks like the CI is just installing a couple system packages and installing/building bacio, w3emc, and jasper. The list of dependencies is pretty long, so probably a good idea to do them in batches.

Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I'm happy to turn on Actions for this repo.

This is a nice step to help us safety check GNU compilers where we were not before.

@christopherwharrop-noaa
Copy link
Collaborator

@christinaholtNOAA - I already turned actions on. But it hasn't taken effect for this PR for some reason.

@christinaholtNOAA
Copy link
Collaborator

I think it will have to be merged first.

Copy link
Collaborator

@christopherwharrop-noaa christopherwharrop-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to do an eyeball test of a CI workflow, but we seem to have a chicken and egg problem getting the CI to turn on, so will approve to initiate that.

@christopherwharrop-noaa christopherwharrop-noaa merged commit 0000349 into NOAA-GSL:develop Jun 23, 2023
@christinaholtNOAA
Copy link
Collaborator

Unfortunately, I haven't run across any other great way to fully test a GHA workflow.

@edwardhartnett
Copy link
Contributor Author

@christopherwharrop-noaa as indicated this is only "part of" #33.

It's best to develop the CI system in iterations. But the CI won't start running until we get the first one merged to develop. ;-)

So merge this partial CI workflow, and I will fill in the rest, and let the workflow run as I do so to ensure that it's working.

The list of dependencies is long but not much longer than we already handle for UFS_UTILS. Once we get up and running I will demonstrate how we can test against different versions of the dependencies.

@edwardhartnett edwardhartnett deleted the ejh_ci branch June 23, 2023 13:48
@christopherwharrop-noaa
Copy link
Collaborator

The CI is running now after I merged it. We should be good to go for the next iteration. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants