Integrate run fcst

[NaureenBharwaniNOAA]

DESCRIPTION OF CHANGES:

Status update run_fcst:

• Fork from SRW on the branch integrate-run-fcst.

• Run dir on Hera, /scratch1/BMC/zrtrr/Naureen.Bharwani/SRW_uwtools_integration/ufs-srweather-app

• Currently I’ve been trying to get a single test to pass, which is the grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta fundamental test.

• The task that currently fails is run_fcst_mem000.

• The error I’m seeing is relating to the config_defaults, task_run_fcst section of the YAML within the namelist.update_values, namelist.update_values.fv_core_nml and module_config.update_values blocks.

The error I’m encountering:

[2024-11-07T14:32:02]     INFO Validating config against internal schema: fv3
[2024-11-07T14:32:02]    ERROR 8 UW schema-validation errors found in fv3 config
[2024-11-07T14:32:02]    ERROR Error at fv3 -> model_configure -> update_values -> write_groups:
[2024-11-07T14:32:02]    ERROR   !int is not of type 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> model_configure -> update_values -> write_tasks_per_group:
[2024-11-07T14:32:02]    ERROR   !int is not of type 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> nam_sfcperts:
[2024-11-07T14:32:02]    ERROR   {} should be non-empty
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> nrows_blend:
[2024-11-07T14:32:02]    ERROR   !int {{ grid_params.HALO_BLEND }} is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> target_lon:
[2024-11-07T14:32:02]    ERROR   !int -97.5 is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> stretch_fac:
[2024-11-07T14:32:02]    ERROR   !int 0.999 is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> target_lat:
[2024-11-07T14:32:02]    ERROR   !int 38.5 is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> nam_sppperts:
[2024-11-07T14:32:02]    ERROR   {} should be non-empty

Ideas for a solution:
After looking into the JSON Schema for fv3 driver and the namelist. I believe that we need to adjust the schema to allow type number for the entries above in the namelist block. This will allow floating point values to be accepted. With just the integer type it does not accept floating point values, although it does accept negative values. We might also need to add the individual keys to the fv3 schema itself since the namelist schema is shared by all drivers and this could cause users to give inappropriate values for other keys in different drivers. I tested it by adding to the namelist schema the type number. That didn't seem to fix the schema issue. With the same error appearing.

Resource on JSON Schema type number.

Type of change

• New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

• hera.intel
• fundamental test suite, single fundamental test see above

[NaureenBharwaniNOAA]

UW schema-validation error

[2024-11-07T14:32:02]    ERROR Error at fv3 -> model_configure -> update_values -> write_groups:
[2024-11-07T14:32:02]    ERROR   !int is not of type 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> model_configure -> update_values -> write_tasks_per_group:

[NaureenBharwaniNOAA]

UW schema-validation error

[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> nam_sfcperts:
[2024-11-07T14:32:02]    ERROR   {} should be non-empty

[NaureenBharwaniNOAA]

I previously had a fail run where nam_sfcperts and nam_sppperts were missing, but were required arguments for the test. I added these into the config_defaults as empty dictionaries since I wasn’t sure what the key / value pairs would look like and if they would be a dict. The test is failing for both of these keys because the value cannot be an empty dict.

[NaureenBharwaniNOAA]

This seems odd and I noticed when looking into the schema errors. Possibly this error fits with the arbitrary schema-validation error message

[2024-11-07T14:32:02]    ERROR   !int is not of type 'boolean', 'number', 'string'

[NaureenBharwaniNOAA]

UW schema-validation errors

[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> nrows_blend:
[2024-11-07T14:32:02]    ERROR   !int {{ grid_params.HALO_BLEND }} is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> target_lon:
[2024-11-07T14:32:02]    ERROR   !int -97.5 is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> stretch_fac:
[2024-11-07T14:32:02]    ERROR   !int 0.999 is not of type 'array', 'boolean', 'number', 'string'
[2024-11-07T14:32:02]    ERROR Error at fv3 -> namelist -> update_values -> fv_core_nml -> target_lat:
[2024-11-07T14:32:02]    ERROR   !int 38.5 is not of type 'array', 'boolean', 'number', 'string'

[NaureenBharwaniNOAA]

This also needed to be added back in. I set the value as false to mimic what the value was previously.

[NaureenBharwaniNOAA]

Again, needed to be added back in.

[christinaholtNOAA]

Thanks for adding this summary here. I think there are some early-in-the-process gaps in how/where the values are referenced that are leading to Jinja expressions not being rendered. I can certainly look into those more closely.