Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uwtools_integration] Integrate run_fcst #271
base: uwtools_integration
Are you sure you want to change the base?
[uwtools_integration] Integrate run_fcst #271
Changes from 40 commits
2d77662
4b03af5
1c7faec
12f938c
4249ce2
c596c95
03e01d1
16e2ac0
9947701
3e7584e
89e9fd1
caec469
2e4eec1
aca7d70
0b92eb1
18ff149
52f3c0f
2c08014
5cf2b78
d22af95
0bf8940
a4327be
5ecc61f
63cb2f5
4cdabd7
67a461c
4951956
7c82f63
647a0fd
1ad0a41
2f0a8c2
ea236bd
28c031f
4535696
72c330d
9bfc486
2466c09
6a7a848
973a71f
86ec15f
5a8a7de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was a lot of shell-based stuff that didn't work with "flattening" the YAML in the run scripts. The relevant information has been moved to the FV3 YAML.
Two sections remain here. The first describes the list of variables that come out of make_sfc_climo, which the UW Driver could absorb once the
output
method is instantiated on that class. The second describes the set of required fix files the Thompson mp scheme needs. Perhaps those belong over inccpp_suites_defaults.yaml
? I'll take another peek at that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those Thompson mp input files eventually involved in a
uw fs copy
orlink
action? Mostly just curious how the list is used w.r.t.uwtools
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. They do eventually get added to the
files_to_link
section of the fv3 UW YAML. Instead of listing the names of CCPP Suites that use Thompson MP, though, SRW calls a function that loads the XML to find out if Thompson is used. I could definitely clean up this section and move it over to CCPP suites to put it closer to its other relevant settings.