Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of the InitialDataAdder abstraction #383

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Addition of the InitialDataAdder abstraction #383

merged 6 commits into from
Jul 11, 2023

Commits on Jul 10, 2023

  1. Add InitialDataAdder abstract type and usage. 

    Creating abstract InitialDataAdder type for use with creating datasets,
and modifying Dataset.create abstract function to use this type for the
'initial_data' parameter, rather than a string that represents the
location of some kind of initial data.
    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a4baa13 View commit details
    Browse the repository at this point in the history

  2. Update ObjectStoreManager for InitialDataAdder. 

    Updating DatasetManager implementation's create function to support
usage of the InitialDataAdder abstraction for the 'initial_data' param.
    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    057807f View commit details
    Browse the repository at this point in the history

  3. Bump dmod.core version to 0.9.0.

    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c93220f View commit details
    Browse the repository at this point in the history

  4. Update dmod.modeldata dep for dmod.core. 

    Updating to depend on core 0.9.0.
    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    5ea4f92 View commit details
    Browse the repository at this point in the history

  5. Bump dmod.modeldata version to 0.9.2.

    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7eef8e9 View commit details
    Browse the repository at this point in the history

  6. Use delete w/ obj store mgr create() if add fails. 

    Fixing ObjectStoreDatasetManager create() function so that it calls the
delete() function if initial data fails to be added (and thus the
dataset does not need to end up created); previous logic that just
removed the bucket would fail if the bucket had anything in it.
    @robertbartel
    robertbartel committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b2847f0 View commit details
    Browse the repository at this point in the history