Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward Dataset field references to resolve DatasetManager type #385

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Forward Dataset field references to resolve DatasetManager type #385

merged 1 commit into from
Jul 10, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 10, 2023

Dataset's manager field is an Optional['DatasetManager'], however DatasetManager is defined after Dataset. Thus, Dataset's field references need to be forwarded.

fixes #376

Changes

@aaraney aaraney added the bug Something isn't working label Jul 10, 2023
@robertbartel robertbartel added the maas MaaS Workstream label Jul 10, 2023
@robertbartel robertbartel merged commit 2fd9203 into NOAA-OWP:master Jul 10, 2023
1 check passed
@robertbartel robertbartel mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbartel robertbartel robertbartel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset needs references forwarded
2 participants
@aaraney @robertbartel