Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content_type to metadata file on python/lib/modeldata/dmod/modeld… #387

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Add content_type to metadata file on python/lib/modeldata/dmod/modeld… #387

merged 2 commits into from
Jul 21, 2023

Conversation

viktoriussuwandi
Copy link
Contributor

issue#320

Hi aaraney,
just trying to help on this issue on file python/lib/modeldata/dmod/modeldata/data/object_store_manager.py, please check it out

Additions

Removals

Changes

Add content_type to metadata file on python/lib/modeldata/dmod/modeld

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • No linting errors or warnings

@viktoriussuwandi
Copy link
Contributor Author

viktoriussuwandi commented Jul 18, 2023

Hi @aaraney, anything else to complete this PR ?

Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @viktoriussuwandi, thanks so much for making this change! This is exactly what was needed! 🎉

closes #320

@aaraney aaraney merged commit db4ca5e into NOAA-OWP:master Jul 21, 2023
2 checks passed
robertbartel pushed a commit to robertbartel/DMOD that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants