Django Testing Additions #421
Conversation
and added Django testing to the run_tests script
added a line to the django test script to help shed light on issues if things don't work right.
There was a problem hiding this comment.
I have one minor request and then we should be on the way. Thanks, @christophertubbs!
| DEFAULT_ROOT = str(APPLICATION_ROOT / "python") | ||
| """The root of the python libraries and services""" | ||
|
|
||
| MANAGE_MARKER = "os.environ.setdefault('DJANGO_SETTINGS_MODULE'" |
There was a problem hiding this comment.
Is there a missing closing paren here?
There was a problem hiding this comment.
| MANAGE_MARKER = "os.environ.setdefault('DJANGO_SETTINGS_MODULE'" | |
| MANAGE_MARKER = "os.environ.setdefault('DJANGO_SETTINGS_MODULE')" |
There was a problem hiding this comment.
That won't work - the marker is supposed to match on lines like x = os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'something.settings'). Cutting it off with the ) character will prevent it from matching on what it needs to match on.
| file=sys.stderr | ||
| ) | ||
| # Exit with a code of -1 to indicate that this was an application error, not a test error or failure | ||
| exit(-1) |
There was a problem hiding this comment.
POSIX exit codes are unsigned 8 bit integers. Fortunately, python is smart enough and wraps this around to 255, but you may want to change this to some other meaningful positive number.
| message = TestMessage(status=current_status, content=current_content, description=current_description) | ||
| self.messages.append(message) | ||
|
|
||
| def print(self, verbose: bool = None, quiet: bool = None): |
There was a problem hiding this comment.
I think both verbose and quiet's default value should be False instead of None here.
Changed the default variables for quiet and verbose from None to False
|
Thanks @christophertubbs! Merge at will! |
incremented the version for the evaluationservice added dmod_venv to the gitignore
Added venv activation and deactivation around the django tests added missing logic to append django errors to the total error count
Added specialized testing functionality for all django applications