Move DMOD service images and service Python packaging image to Rocky Linux base #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbartel
force-pushed
the
b/service_images_rocky/main
branch
from
0707ea5
to
1892ded
Compare
Updating to new base image to address problems with previous alpine base, including no longer having to pre-build wheels of several dependencies (e.g., pandas), which had become broken.
Removing py-deps image/service from py-sources stack, as this was primarily added to cleanly contain the layers that custom-built several wheels for service package dependencies, which is no longer required after moving from an Alpine Linux base image to Rocky Linux.
robertbartel
force-pushed
the
b/service_images_rocky/main
branch
from
1892ded
to
13c6c25
Compare
|
Is this ready to review or are you considering targeting rocky 9 after our conversation earlier, @robertbartel? For a little context, there is an ongoing discussion if NextGen needs to support GCC 8. This discussion centers around the absence of c++ std smart pointer types in GCC 8. Coincidentally, rocky linux 8's package repo ships GCC 8.5 where as rocky linux 9 ships GCC 11. |
|
I am still considering moving the ngen images (and the others) to 9.1, but it turned out that 9.1 didn't help with the problem I was having. Since it isn't immediately helpful/necessary, I don't want to rush to make that change. For now, let's move forward with 8.5 on this one. |
aaraney
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
mainstack service images and thepy-sourcesimage (on which the service images depend) to a base of Rocky Linux. This removes the need for several pre-built wheels and simplifies the build overall, at the cost of slightly larger images.These changes resolve some issues causing image builds to currently fail, as tracked in #425.