-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ngen Docker image to build t-route master branch #429
Merged
robertbartel
merged 14 commits into
NOAA-OWP:master
from
robertbartel:f/troute_master/1/rebase
Sep 18, 2023
Merged
Update ngen Docker image to build t-route master branch #429
robertbartel
merged 14 commits into
NOAA-OWP:master
from
robertbartel:f/troute_master/1/rebase
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er python modules will be installed there (instead of in mpi's user site), and can be readily used if the container is launched with uid=X... a useful scenario for reusing this container image.
Updating docker-build.yml for main stack compose config to default to official OWP repo and "master" branch in relevant t-route build ARGs, instead of failing with an error message if they were not set within the .env config.
Adding dummy file to help avoid copy issues during Docker image builds if there is no Boost tar file present, while allowing the build to take advantage of a local Boost tar file when it is.
Taking advantage of new dummy file, rather than the image's entrypoint (which would be prone to change and thus reduce build cache hits) to help avoid copy issues during Docker image builds if there is no Boost tar file present, while allowing the build to take advantage of a local Boost tar file when it is.
- Create symlinks for python/pip from python3/pip3 - Run dnf clean all - Use --no-cache-dir with pip installs
Separating layers handling Python dependencies for troute that needed some of the from-source dependencies.
12 tasks
Fixing issue where main ngen worker and calibration images would not necessarily be built using the same ngen branch or commit due to the Docker compose build config not applying all ngen .env-sourced ARGS to the calibration image build.
aaraney
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to building/installing t-route master instead of t-route ngen branch. Very similar to changes from #318, but with some modifications based on initial review and evolution of the repo since.
Additions
${BUILD_PARALLEL_JOBS}
instead of$(nproc)
Removals
Changes