Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use list type hint from typing lib to support 3.8 #465

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Use list type hint from typing lib to support 3.8 #465

merged 1 commit into from
Nov 2, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Nov 2, 2023

fixes #464

Changes

  • Fix typing bug in dmod.core.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

christophertubbs
christophertubbs approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I think I have another PR that uses list instead of typing.List, so I'm going to look around for that

@christophertubbs christophertubbs merged commit 3f41bbb into NOAA-OWP:master Nov 2, 2023
1 check failed
@aaraney aaraney mentioned this pull request Nov 2, 2023
Merged
11 tasks
@aaraney
Copy link
Member Author

aaraney commented Nov 2, 2023

@christophertubbs, I greped the repo and didnt find any other occurrences.

@aaraney
Copy link
Member Author

aaraney commented Nov 2, 2023

another PR

I see, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertubbs christophertubbs christophertubbs approved these changes

@robertbartel robertbartel Awaiting requested review from robertbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python 3.8 gh actions failing because list is used instead of typing.List
2 participants
@aaraney @christophertubbs