Fix hydrofabric unique id generation #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing to ensure deterministic ordering of layers. Should address NOAA-OWP#468.
aaraney
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks for fixing this, @robertbartel! This does not fully resolve the issue in #468, but is a step in the right direction.
|
I did forget to actually fix the tests, and in fixing them I realized I had reversed things in my manual test of this fix on a second machine. I.e., this by itself isn't giving consistent hashes across machines. I'll leave as draft for now in case an additional adjustment ends up making this useful. |
|
I just posted a few potential solutions to the issue in #468 if you want to have a look. In short, either pin |
|
If all is well in #478, we can close this in favor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing to ensure deterministic ordering of layers when building hash. Should address #468.