Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(py38): port functools.cache support #483

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jan 23, 2024

Fix ImportError: cannot import name 'cache' from 'functools' bug present in python3.8.

dmod.scheduler -- 0.10.1

Changes

  • Fix ImportError: cannot import name 'cache' from 'functools' bug present in python3.8.

@aaraney
Copy link
Member Author

aaraney commented Jan 23, 2024

tests are failing b.c. of something that will be addressed in #424.

Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. I wouldn't have thought of the type guard and I like your use of the tuple check - I don't remember the way I usually do it, but this is better.

@christophertubbs christophertubbs merged commit 9c16daa into NOAA-OWP:master Jan 23, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants