Remove deprecated websockets.serve loop arg #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated
websockets.serve
loop
argument. Tests have been warning that this argument is deprecated for months.dmod.communication
--0.15.2
Removals
asyncio.loop
towebsockets.serve
. This argument is deprecated.Changes
WebSocketInterface
__del__
finalizer only callsself.shutdown()
if the loop is still running. Previously a new loop was created to run the coroutine, but this had no effect.