Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation service function type hints #492

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix evaluation service function type hints #492

merged 1 commit into from
Jan 25, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jan 24, 2024 •
edited
Loading

closes #491.

@aaraney
Copy link
Member Author

aaraney commented Jan 24, 2024

still trying to figure out why they are failing.

@aaraney
Copy link
Member Author

aaraney commented Jan 24, 2024

Figured out what the issue is. typing.Callable[[typing.Any, ...], is not parsable in 3.8.

DMOD/python/services/evaluationservice/dmod/evaluationservice/evaluation_service/wrapper.py

Line 52 in a9f5440

function: typing.Callable[[typing.Any, ...], typing.Union[_MODEL_TYPE, typing.Sequence[_MODEL_TYPE]]],

@aaraney aaraney changed the title Add evaluation service placeholder testing package Fix evaluation service function type hints Jan 25, 2024
christophertubbs
christophertubbs approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes all around - didn't know you didn't have to declare the ParamSpec beforehand.

We might need to find a solid way to only use typing_extensions only when the item isn't supported by typing yet.

@christophertubbs christophertubbs merged commit a725d13 into NOAA-OWP:master Jan 25, 2024
4 checks passed
@aaraney aaraney mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertubbs christophertubbs christophertubbs approved these changes

@robertbartel robertbartel Awaiting requested review from robertbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.8 tests failing due to evaluation service?
2 participants
@aaraney @christophertubbs