Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RedisDockerSwarmMonitor type hints #493

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix RedisDockerSwarmMonitor type hints #493

merged 2 commits into from
Jan 30, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jan 25, 2024

Fix RedisDockerSwarmMonitor type hints

dmod.monitor -- 0.3.2

Changes

  • Fix RedisDockerSwarmMonitor type hints

christophertubbs
christophertubbs approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the formatting.

Stylistic note: typing.Optional is not necessary when you're setting a default to None.

@christophertubbs christophertubbs merged commit f6b658b into NOAA-OWP:master Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertubbs christophertubbs christophertubbs approved these changes

@robertbartel robertbartel Awaiting requested review from robertbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaraney @christophertubbs