Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: account for nested directories #516

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Feb 1, 2024

Account for nested directories in modeldata integration tests. These tests will continue to fail until #512 is merged.

@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels Feb 2, 2024
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how I thought the API worked, though I could be wrong. I thought it flattened everything inside the bucket, and just prefixed a faux ancestor path as part of object names to emulate a directory structure. But as long as you've confirmed this still operates as needed, I'm good with it (I don't think it would break the current test even if it was wrong because of how the test data is structured).

I am having unrelated issues with getting these tests to work in my own setup, so just to be safe I am going to leave it to you to actually merge it in. It might not hurt to rebase the stuff from #512 first so we can see tests passing, but I'll leave that to you.

@aaraney
Copy link
Member Author

aaraney commented Feb 5, 2024

That's not how I thought the API worked, though I could be wrong. I thought it flattened everything inside the bucket, and just prefixed a faux ancestor path as part of object names to emulate a directory structure.

Yeah you are right that directories don't really exist. However, minio and s3 preserve the idea of a directory by treating and objects that contain a / in their name as if they were in a directory when you perform operations.

https://min.io/docs/minio/linux/developers/python/API.html#list_objects

recursive bool List recursively than directory structure emulation.

@aaraney
Copy link
Member Author

aaraney commented Feb 5, 2024

It might not hurt to rebase the stuff from #512 first so we can see tests passing, but I'll leave that to you.

Yeah I think that is a great caveat. Just rebased and force pushed.

@aaraney
Copy link
Member Author

aaraney commented Feb 5, 2024

All the modeldata integration tests are passing now. Going to go ahead and merge this. Thanks again, @robertbartel!

@aaraney aaraney merged commit ce624aa into NOAA-OWP:master Feb 5, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants