Fix modeldata.geopackge_hydrofabric type hints
#523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are odd. Not sure what is going on. Cleared all the runner caches and trying to run them again. |
|
Not sure what was going on with the tests. Seemingly an issue with package cache? |
|
@robertbartel, since this doesn't change behavior, I figured it doesn't need a version bump. Thoughts? Happy to patch if desired. JLMK |
robertbartel
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #311
Changes
GeoPackageCatchmentandGeoPackageNexusmethod type hints. See Update to new hypy dependency and fix catchment class type hinting #311 for specifics.