Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CLI function implementations #525

Merged
merged 43 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. Adjust event type docs and Response superclass.

    - Adjusting the documentation of MessageEvenType.SCHEDULER_REQUEST to
      broaden its applicability beyond initiating a job.
    - Making Response extend from BasicResultIndicator so that the 'data'
      attribute can be implemented just once (and correctly)
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4c5fefc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e058eb1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9835838 View commit details
    Browse the repository at this point in the history
  4. Bump scheduler service comms dep to 0.17.0.

    Bumping communication package dependency version required by scheduler
    service package.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    69cca38 View commit details
    Browse the repository at this point in the history
  5. Add scheduler service funcs for job control/info.

    Adding several private functions to the scheduler service handler for
    handling new messages for job information or control requests.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f82c441 View commit details
    Browse the repository at this point in the history
  6. Update schedulerservice listener for new job msgs.

    Updating listener function with redesigned logic for processing incoming
    messages that includes handling of new message types for handling
    requests for job information or to control existing jobs.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    51588b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d3456fa View commit details
    Browse the repository at this point in the history
  8. Add new job status steps related to stopping.

    Added STOPPING (for when a job has been requested to be stopped, but
    before it has) and CANCELED (when a STOPPED job has its resources
    released) JobExecStep values.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    92d2a71 View commit details
    Browse the repository at this point in the history
  9. Update JobImpl.should_release_resources func.

    Allow for releasing resources in CANCELED or COMPLETED steps.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9a1bae5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e545d5a View commit details
    Browse the repository at this point in the history
  11. Refactor RedisBackedJobUtil.get_all_active_jobs.

    Rewriting to implement via list comprehension rather than loop.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2dc1042 View commit details
    Browse the repository at this point in the history
  12. Add get_job_ids to JobUtil interface.

    Adding function to get all job ids to interface, and updating redis impl
    for this; also modifying tracking of active jobs to track job id, rather
    than job key.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d18c1a1 View commit details
    Browse the repository at this point in the history
  13. Modify release_allocations for JobManager.

    Modify release_allocations func in JobManager interface and Redis impl:
    
    - accept either a job object reference or a job id as the param
    - return a BasicResultIndicator, rather than nothing
    - updating Redis impl specifically to only act on a job in a state that
      makes it eligible to release resources
    - updating Redis impl specifically to include logic to saving the
      updated job object
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b5b0ed2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    870613c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    35914e5 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a615dfd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    901cfac View commit details
    Browse the repository at this point in the history
  18. Refactor SchedulerHandler class method name.

    Renaming get_parseable_request_funcs to _get_parseable_request_funcs to
    indicate it isn't intended for use outside the class and its instances.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    004cb7d View commit details
    Browse the repository at this point in the history
  19. Add external request handler for existing job msg.

    Adding new ExistingJobRequestHandler for handling externally sourced
    JobControlRequest, JobInfoRequest, and JobListRequest messages.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    febbb97 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    2319d16 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d2c5e38 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    decf61c View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    ce848db View commit details
    Browse the repository at this point in the history
  24. Support existing job messages in requestservice.

    Add support for handling JobControlRequest, JobInfoRequest, and
    JobListRequest in main request service handler.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6f01afa View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d47cf5a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    ccc2b5f View commit details
    Browse the repository at this point in the history
  27. Update client JobClient with job-related funcs.

    Adding implementations for request_job_info, request_job_release,
    request_job_resume, request_job_status, request_job_stop, and
    request_jobs_list functions.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cf71737 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    45ee38b View commit details
    Browse the repository at this point in the history
  29. Correct forward lookup issue in scheduler.py.

    Note that proper fix is out of scope for this; this addresses immediate
    failures loading module.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cf460a4 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    94203be View commit details
    Browse the repository at this point in the history
  31. Fix deprecated attribute "set"s in test file.

    Move "set" of several attribute values in it_RedisBackedJobManager.py to
    use of setter functions.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    42c4bcf View commit details
    Browse the repository at this point in the history
  32. Update tests for changes to release_allocations.

    Updating it_RedisBackedJobManager.py to account for changes in the
    implementation of the release_allocations function, including some
    expansion to test coverage.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1367baa View commit details
    Browse the repository at this point in the history
  33. Fix deprecated job_id set in job_manager.py.

    Moving to use of setter.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8b600fe View commit details
    Browse the repository at this point in the history
  34. Rename func to JobClient.request_job_restart.

    Adjusting function name from request_job_resume to request_job_restart
    to distinguish (hopefully) this is restarting a previously running job.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    578b9a3 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    0a414f2 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    5822e5f View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    0c2e1c0 View commit details
    Browse the repository at this point in the history
  38. Update and refactor request_clients.py functions.

    Updating newly implemented job query and control functions in JobClient
    to account fully for failure scenarios, and refactoring to centralize
    mostly duplicate routines that lent themselves well to shared
    parameterized functions.
    robertbartel committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    bb163e1 View commit details
    Browse the repository at this point in the history
  39. Update python/lib/communication/dmod/communication/maas_request/job_m…

    …essage.py
    
    Co-authored-by: Austin Raney <[email protected]>
    robertbartel and aaraney committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a2c0a47 View commit details
    Browse the repository at this point in the history
  40. Update python/lib/communication/dmod/communication/maas_request/job_m…

    …essage.py
    
    Co-authored-by: Austin Raney <[email protected]>
    robertbartel and aaraney committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    009f503 View commit details
    Browse the repository at this point in the history
  41. Update python/lib/communication/dmod/communication/maas_request/job_m…

    …essage.py
    
    Co-authored-by: Austin Raney <[email protected]>
    robertbartel and aaraney committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2577a32 View commit details
    Browse the repository at this point in the history
  42. Update python/lib/externalrequests/dmod/externalrequests/maas_request…

    …_handlers.py
    
    Co-authored-by: Austin Raney <[email protected]>
    robertbartel and aaraney committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1eddbf0 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    3c38a17 View commit details
    Browse the repository at this point in the history