Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a skip statement for an invalid test for the template manager #636

Merged

Conversation

christophertubbs
Copy link
Contributor

A stub of a test with incomplete implementation was being run again. A skip statement was added to it to prevent testing until properly implemented

@aaraney
Copy link
Member

aaraney commented May 28, 2024

Seems like there are still some failing django unit tests. Ive not tried to reproduce locally, @christophertubbs. Any idea what is going on?

@christophertubbs
Copy link
Contributor Author

It's a code failure, not a test failure. I can't replicate locally and I've got latest.

@aaraney
Copy link
Member

aaraney commented May 28, 2024

Looks like this might have been a caching issue or just a dependency not being picked up that was added in requirements.txt.

@christophertubbs christophertubbs merged commit ebf1965 into NOAA-OWP:master May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants