Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed_several_issues #129

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fixed_several_issues #129

merged 3 commits into from
Sep 4, 2024

Conversation

ajkhattak
Copy link
Contributor

@ajkhattak ajkhattak commented Sep 3, 2024 •
edited
Loading

The PR fixed issues created via git issues. These changes don't change the functionality of the model.

  1. closed Incorrect unit for RAIN_RATE ouput #58 -- fixed RAIN_RATE units
  2. closed "RAIN_RATE" output unit in m, but it is actually mm  #69 -- new units are in m
  3. closed Should nash_storage_subsurface & nash_storage_surface be a 1d arrays of doubles? #124 (updated docs)
  4. closed Add expected unit warning to relevant configuration parameters #125 (fixed missing units warnings)

Additions

  • None

Removals

  • None

Changes

  • No changes to the functionality

Testing

  1. All existing tests passed

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

hellkite500
hellkite500 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@hellkite500 hellkite500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, just a small comment on the need for unit parsing and warnings but otherwise, should be mergeable as is...

src/bmi_cfe.c Show resolved Hide resolved
@ajkhattak ajkhattak merged commit 2b1372e into master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellkite500 hellkite500 hellkite500 approved these changes

@madMatchstick madMatchstick Awaiting requested review from madMatchstick

@aaraney aaraney Awaiting requested review from aaraney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ajkhattak @hellkite500