removed N_nash_subsruface bmi parameter

[ajkhattak]

The PR removed the bmi parameter N_nash_subsurface from the list of calibratable parameters as we don't calibrate it.

Additions

• None

Removals

• remove N_nash_subsurface

Testing

1. All existing tests passed

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Reviewers requested with the Reviewers tool ➡️

[aaraney]

I left a few suggestions for denoting if a parameter is calibratable or only applicable when surface_runoff_scheme is NASH_CASCADE. Purely stylistic and subjective; Certainly not required.

The code modifications look solid.

[SnowHydrology]

@aaraney Did you build and run CFE with the changes?

[aaraney]

@SnowHydrology, I did not. I trusted that the GH actions would have failed if there was an issue.

[madMatchstick]

@SnowHydrology, I did not. I trusted that the GH actions would have failed if there was an issue.

Also - note that surface_runoff_scheme=NASH_CASCADE is tested for CFE v2.0, here. Looks good to me.

[SnowHydrology]

After README cleanup, this can be merged

[ajkhattak]

thanks all for the review, I have merged/incorporated @aaraney suggestions

[aaraney]

Looks great! Thanks for making the changes, @ajkhattak! 🎉

No longer applicable