Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fsds to fs across python & R packages #23

Open
wants to merge 111 commits into
base: main
Choose a base branch
from

Conversation

glitt13
Copy link
Collaborator

@glitt13 glitt13 commented Oct 13, 2024

Renamed all things fsds to fs (formulation-selector) in the python & R code base.
Also integrated the NWIS gage ID checker/corrector into the standard fs_proc processing

Additions

Integrated the check_nwis logic into proc_col_schema()

Removals

Changes

Testing

  1. All unit tests passed corresponding to the fs_proc and fs_algo packages modified fsds to fs
  2. Unit test created for the NWIS checker, check_fix_nwissite_gageids

Screenshots

Notes

Todos

  • Still need to modify fsds naming in the R code, but will do so once the existing PR review is accepted to reduce merge conflicts.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

glitt13 and others added 30 commits August 22, 2024 09:29
describe the unique dependencies
…fix associated functions when behavior didn't follow expected behavior
…go_train_eval module; feat: move some hard-coded variables into the algorithm config file
@glitt13
Copy link
Collaborator Author

glitt13 commented Oct 14, 2024

Note that changing fs_proc to rafts_proc will be easy - let's discuss preferred package naming.

glitt13 and others added 20 commits October 14, 2024 09:04
Add nwissite gage_id format checker to standard processing
Minor fix and doc update
Update hyperlinks and descriptions with latest fsds to fs change, and OWP repo location.
doc: minor path fix
@glitt13
Copy link
Collaborator Author

glitt13 commented Oct 16, 2024

@bolotinl, note that this PR also includes a new feature: adding the pre-existing check_nwis_gage_id_fix() function to become a standard check inside proc_col_schema() when NWIS gage data are used as the gage_id. This PR also added the new unit test corresponding to check_nwis_gage_id_fix()

@glitt13 glitt13 changed the title Change fsds to fs in python code Change fsds to fs across python & R packages Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants