generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change fsds to fs across python & R packages #23
Open
glitt13
wants to merge
111
commits into
NOAA-OWP:main
Choose a base branch
from
glitt13:fsds_fs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o modular functions inside package
describe the unique dependencies
…fix associated functions when behavior didn't follow expected behavior
…_train_eval module
…go_train_eval module; feat: move some hard-coded variables into the algorithm config file
Requirements yaml file for conda env
Note that changing fs_proc to rafts_proc will be easy - let's discuss preferred package naming. |
…_nwissite_gageids function
Add nwissite gage_id format checker to standard processing
Minor fix and doc update
Update hyperlinks and descriptions with latest fsds to fs change, and OWP repo location.
doc: minor path fix
@bolotinl, note that this PR also includes a new feature: adding the pre-existing |
… documentation using fs instead of fsds
glitt13
changed the title
Change fsds to fs in python code
Change fsds to fs across python & R packages
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed all things fsds to fs (formulation-selector) in the python & R code base.
Also integrated the NWIS gage ID checker/corrector into the standard fs_proc processing
Additions
Integrated the
check_nwis
logic intoproc_col_schema()
Removals
Changes
Testing
check_fix_nwissite_gageids
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other