Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: New tool to adjust HAND wse using ras2fim results #1196

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AliForghani-NOAA
Copy link
Collaborator

@AliForghani-NOAA AliForghani-NOAA commented Jun 20, 2024

This PR adds a new tool, which is still in progress. The tool addresses the issue #994 (but is not going to close this issue yet).
The tool aims to update the HAND SRC by comparing water surface elevation (WSE) between RAS2FIM and HAND. The algorithm is as below:

  • For each RAS cross section, determine the HAND discharge adjustment (Q_Adjust):
    • HAND minimum WSE is assumed the same as HAND Hydro-conditioned DEM
    • RAS2FIM minimum WSE is already available from HEC-RAS runs.
    • Calculate the difference between the minimum WSE values of RAS2FIM and HAND, and call it "WSE_base_error". This difference can address the bathymetry error in HAND SRC.
    • Add stage values into RAS2FIM rating curves (by subtracting DEM from WSE), and then interpolate a discharge for the "WSE_base_error". This interpolated discharge is called "Q_Adjust."
  • Calculate the median of "Q_Adjust" values for cross sections within HAND catchments.
  • Add the median "Q_Adjust" values to the flows of HAND SRC

Additions

  • tools/adjust_wse_with_ras2fim.py

Testing

The code has ben applied on results of RAS2FIM and HAND-FIM runs for HUC 12090301. Table below compares the MAE of the difference between RAS2FIM and HAND before and after updating the HAND SRC using above algorithm. The results are based on using 'precalb_discharge_cms' column of HAND HydroTable.
image

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@AliForghani-NOAA AliForghani-NOAA self-assigned this Jun 20, 2024
@AliForghani-NOAA AliForghani-NOAA added FIM4 enhancement New feature or request labels Jun 20, 2024
@AliForghani-NOAA AliForghani-NOAA changed the title added code to adjusy wse using ras2fim results [1pt] PR: New tool to adjust HAND wse using ras2fim results Jun 20, 2024
@AliForghani-NOAA AliForghani-NOAA marked this pull request as ready for review June 20, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FIM4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant