Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cfe, topmodel, and lgar calibratable parmeters; ngen.cal python < 3.9 pin fiona<1.10.0 #187

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Sep 4, 2024

ngen.config

Additions

  • LgarParams
  • docstrings for CfeParams, TopmodelParams, and LgarParams parameters
  • New CfeParams and TopmodelParams calibratable parameters

Removals

ngen.cal

Changes

  • ngen.cal on python 3.9 pins fiona<1.10.0 (see notes)

Notes:

fiona v1.10.0 deprecated fiona.path field (seem to have been removed?) see.

geopandas geojson reader uses fiona.

geopandas v0.14 dropped support for python<3.9. So, ngen.cal installations are effectively pinned to geopandas<=0.14. Transitively, ngen.cal needs to pin fiona<1.10.0 for compatibility.
https://geopandas.org/en/stable/docs/changelog.html#version-0-14-sep-15-2023

fiona v 1.10.0 deprecated  'fiona.path' field (seem to have been removed?)
https://github.com/Toblerity/Fiona/releases/tag/1.10.0

geopandas geojson reader uses fiona.

geopandas v0.14 dropped support for python<3.9. so, ngen.cal
installations are effectively pinned to geopandas <= v0.14.
transitively, ngen.cal needs to pin fiona<1.10.0 for compatibility.
https://geopandas.org/en/stable/docs/changelog.html#version-0-14-sep-15-2023
@aaraney aaraney added enhancement New feature or request ngen.config Related to ngen.config package ngen.cal Related to ngen.cal package chore Updating grunt tasks etc; no production code change) feat New software feature; Not build script / CI feature labels Sep 4, 2024
@aaraney aaraney self-assigned this Sep 4, 2024
@aaraney aaraney requested review from hellkite500 and removed request for robertbartel September 4, 2024 16:56
python/ngen_conf/src/ngen/config/cfe.py Outdated Show resolved Hide resolved
python/ngen_conf/src/ngen/config/cfe.py Outdated Show resolved Hide resolved
python/ngen_conf/src/ngen/config/cfe.py Outdated Show resolved Hide resolved
@aaraney aaraney changed the title Update cfe, topmodel, and lgar calibratable parmeters Update cfe, topmodel, and lgar calibratable parmeters; ngen.cal python < 3.9 pin fiona<1.10.0 Sep 7, 2024
@hellkite500 hellkite500 merged commit e3017a3 into NOAA-OWP:master Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change) enhancement New feature or request feat New software feature; Not build script / CI feature ngen.cal Related to ngen.cal package ngen.config Related to ngen.config package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants