Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMIParams's fixed_time_step now defaults to True #52

Merged
merged 3 commits into from
Jul 18, 2023
Merged

BMIParams's fixed_time_step now defaults to True #52

merged 3 commits into from
Jul 18, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 17, 2023

fixes #47

Changes

  • BMIParams's fixed_time_step now defaults to True

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@aaraney aaraney requested a review from hellkite500 July 17, 2023 14:46
hellkite500
hellkite500 previously approved these changes Jul 18, 2023
View reviewed changes
@hellkite500
Copy link
Member

Need version fixup, and maybe a quick note in the package changelog.md???

@aaraney
Copy link
Member Author

aaraney commented Jul 18, 2023

@hellkite500, this should be good to go now. Thanks for the review!

@hellkite500 hellkite500 merged commit 39e2edf into NOAA-OWP:master Jul 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellkite500 hellkite500 hellkite500 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should fixed_time_step parameter default be True?
2 participants
@aaraney @hellkite500