feat: add soil moisture and freeze thaw init config models #96
Conversation
aaraney
force-pushed
the
add-soil-moisture-and-freeze-thaw-init-configs
branch
3 times, most recently
from
0db58c1
to
820b789
Compare
aaraney
force-pushed
the
add-soil-moisture-and-freeze-thaw-init-configs
branch
from
820b789
to
4949d14
Compare
aaraney
force-pushed
the
add-soil-moisture-and-freeze-thaw-init-configs
branch
6 times, most recently
from
a0e9735
to
a10b1f9
Compare
|
Were these TODO's ever addressed?
And can you rebase the conflict? Active development on lgar BMI may require some iterative changes to the lgar init config, but I think we can put these in place and track updates/issues as they are used |
aaraney
force-pushed
the
add-soil-moisture-and-freeze-thaw-init-configs
branch
from
a10b1f9
to
edc67cc
Compare
Nope and looking back I don't think there was enough information in the source code of the bmi modules for me to gather that information. So, the TODOs were more long term, "hey, im thinking about this long term." IMO, I don't think they need to be addressed in this PR. |
|
@hellkite500, just rebased and looked through things again. This should be good to merge now! |
Wrapper around a List[V] that coerces a comma separated string of Vs
(e.g. "1,2,3") into a List[V] (e.g. [1, 2, 3]). The `dict` method is
overridden to return the inner list of Vs instead of {"__root__": [Vs...]}.
As a result, using a CSList[V] as a field type in anther pydantic model
behaves as if it were a List[V] with the added functionality of coercing a
comma separated string into a list of Vs.
The features this model provides could easily be achieved using a field
level validator, so in some ways this is provided as a convenience. This
model is most useful when a field can be multiple types (union type). It
alleviates the need to implement a complex field level validator that
handles all possible union type members.
aaraney
force-pushed
the
add-soil-moisture-and-freeze-thaw-init-configs
branch
from
edc67cc
to
03779d2
Compare
| time_unit = Literal["s", "sec", "", "h", "hr", "d", "day"] | ||
|
|
||
|
|
||
| class IceFractionScheme(str, Enum): |
There was a problem hiding this comment.
I thought these were rainfall runoff partitioning schemes, not Ice Fraction schemes 🤯
Additions
SoilFreezeThaw,SoilMoistureProfileandLGAR-Cconfiguration filesNotes
value_unit_pairmodule #95