Skip to content

Commit

Permalink
Apply spelling/grammar/clarity suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Phil Miller - NOAA <[email protected]>
  • Loading branch information
mattw-nws and PhilMiller committed Aug 17, 2023
1 parent 2b7e89b commit 9db5db1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion include/core/Partition_Parser.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Partitions_Parser {
if( part.at("remote-connections").get_type() == geojson::PropertyType::List )
{
//It is valid to have no remote connections, but the backend property tree parser
//can't represent empty lists/objects, so it turns into an ampty string (which is iterable)
//can't represent empty lists/objects, so it turns into an empty string (which is iterable)
//so we check to ensure the remote connections are a list type (not string) before we attempt
//to process the remote-connections. If they are empty, this step gets skipped entirely.
//Get remote-connections and set the corresponding part_data struct member
Expand Down
12 changes: 6 additions & 6 deletions src/NGen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ int main(int argc, char *argv[]) {

// now create the layer objects

// first make sure that the layer are listede in decreasing order
// first make sure that the layer are listed in decreasing order
boost::range::sort(keys, std::greater<int>());

std::vector<std::shared_ptr<ngen::Layer> > layers;
Expand All @@ -373,7 +373,7 @@ int main(int argc, char *argv[]) {
auto& desc = layer_meta_data.get_layer(keys[i]);
std::vector<std::string> cat_ids;

// make a new simulation time object with a differnt output interval
// make a new simulation time object with a different output interval
Simulation_Time sim_time(*manager->Simulation_Time_Object, time_steps[i]);

for ( std::string id : features.catchments(keys[i]) ) { cat_ids.push_back(id); }
Expand All @@ -392,10 +392,10 @@ int main(int argc, char *argv[]) {
for( int count = 0; count < manager->Simulation_Time_Object->get_total_output_times(); count++)
{
// The Inner loop will advance all layers unless doing so will break one of two constraints
// 1) A layer may not preceed ahead of the master simulation objects current time
// 2) A layer may not preceed ahead of any layer that is computed before it
// The do while loop insures that all layers are tested at least once while allowing
// layers small time steps to be updated more than once
// 1) A layer may not proceed ahead of the master simulation object's current time
// 2) A layer may not proceed ahead of any layer that is computed before it
// The do while loop ensures that all layers are tested at least once while allowing
// layers with small time steps to be updated more than once
// If a layer with a large time step is after a layer with a small time step the
// layer with the large time step will wait for multiple timesteps from the preceeding
// layer.
Expand Down

0 comments on commit 9db5db1

Please sign in to comment.