Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#362: Remove repeated searches for Boost that were picking up mixed versions #564

Merged
merged 1 commit into from
Jul 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/core/catchment/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ target_include_directories(core_catchment PUBLIC
${PROJECT_SOURCE_DIR}/include/core/catchment/giuh
)

# TODO: consider setting a minimum or required version
find_package(Boost)

add_subdirectory("giuh")

target_link_libraries(core_catchment PUBLIC
Expand Down
1 change: 0 additions & 1 deletion src/core/catchment/giuh/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_include_directories(core_catchment_giuh PUBLIC
${PROJECT_SOURCE_DIR}/include/core/catchment/giuh
)

find_package(Boost)
target_link_libraries(core_catchment_giuh PUBLIC
Boost::boost # Headers-only Boost
)
3 changes: 0 additions & 3 deletions src/core/hydrolocation/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ target_include_directories(core_hydrolocation PUBLIC
${PROJECT_SOURCE_DIR}/include/utilities
)

# TODO: consider setting a minimum or required version
find_package(Boost)

target_link_libraries(core_hydrolocation PUBLIC
Boost::boost # Headers-only Boost
)
Expand Down
3 changes: 0 additions & 3 deletions src/core/nexus/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ target_include_directories(core_nexus PUBLIC
${PROJECT_SOURCE_DIR}/include/utilities
)

# TODO: consider setting a minimum or required version
find_package(Boost)

target_link_libraries(core_nexus PUBLIC
Boost::boost # Headers-only Boost
)
Expand Down
2 changes: 0 additions & 2 deletions src/geojson/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ add_library(NGen::geojson ALIAS geojson)
target_include_directories(geojson PUBLIC
${PROJECT_SOURCE_DIR}/include/geojson
)
# TODO: consider setting a minimum or required version
find_package(Boost)
target_link_libraries(geojson PUBLIC
Boost::boost # Headers-only Boost
)