Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to remove dependencies on internal models #594

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Refactor tests to remove dependencies on internal models #594

merged 4 commits into from
Aug 7, 2023

Commits on Aug 1, 2023

  1. Useful notes on example case differences (and whitespace unification)

    @mattw-nws
    mattw-nws committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a676c5d View commit details
    Browse the repository at this point in the history

  2. Refactored tests to use BMI test models

    @mattw-nws
    mattw-nws committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    70b7449 View commit details
    Browse the repository at this point in the history

  3. Actually, this is better, especially since we will want 0 extra steps… 

    … to get test_bmi_cpp for example realization config purposes.
    @mattw-nws
    mattw-nws committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    32958d4 View commit details
    Browse the repository at this point in the history

  4. Removed test_bmi_c from test_unit tests since it doesn't seem to actu… 

    …ally add any value to have more than one module tested here, and adding it would require different build flags to ngen. Using only the test_bmi_cpp mock, it would be relatively easy in the future to make Bmi_Formulation less "abstract" and support C++ BMI models not in a shared library, removing the need to compile the module in extern explicitly.

Conflicts:
	.github/workflows/test_and_validate.yml
    @mattw-nws
    mattw-nws committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b348075 View commit details
    Browse the repository at this point in the history