-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes top-level tshirt models #597
Removes top-level tshirt models #597
Conversation
This looks good to me once the predecessors are merged and this gets rebased. |
It is worth pointing out that these legacy formulations (including LSTM) are |
It is worth pointing out that my trackpad is garbage. |
It is worth pointing out that these legacy formulations (including LSTM) are responsible for the essentially broken behavior of all current forcing providers that implement |
I'm +1 once 595 is merged (and hence 594 before it) |
…t is. This should probably be a workflow test not a GoogleTest, and it shouldn't test the results against another piece of code inside the project--it looks more like this is testing tshirt, not the other way around, or at least it's not clear which is being tested--this should probably be a test against known static values. Plus, it requires tshirt and probably the et_calc stuff, which we're trying to get down to removal of.
3528728
to
a6be61e
Compare
Builds on/requires #595
Removes tshirt, tshirt_c, associated data and test files, and the Bmi_C_Cfe_IT test (which depended on tshirt).
Additions
Removals
Changes
compare_cfe
target is now gone.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support