Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try updating Github action to v3, since v2 was long-since deprecated #607

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Aug 7, 2023

Changes

  • Switch from checkout@v2 to checkout@v3

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller
Copy link
Contributor Author

Before this PR
https://github.com/NOAA-OWP/ngen/actions/runs/5789781100?pr=606
Screen Shot 2023-08-07 at 4 53 30 PM

And no warnings with it

Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that caught my eye was an additional reference to checkout@v2 in .github/workflows/anchor_containerized_test.yml.disabled. I won't object to leaving it out, but thought I'd mention it.

@PhilMiller
Copy link
Contributor Author

I figured I wasn't going to touch disabled code that I didn't have some familiarity with. Want me to change that one too?

@robertbartel
Copy link
Contributor

@PhilMiller, no, I think it's fine. I can see arguments either way (and I'd probably go back and forth on what I'd do, depending on when I'm asked), but here I was more being extra thorough in case it was accidentally not noticed, rather than consciously left out.

@mattw-nws mattw-nws merged commit ef8e201 into NOAA-OWP:master Aug 8, 2023
20 checks passed
@PhilMiller PhilMiller deleted the phil/github-checkout branch September 23, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants