Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple more missing std:: found with grep #622

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix a couple more missing std:: found with grep #622

merged 1 commit into from
Aug 31, 2023

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Aug 31, 2023 •
edited
Loading

Following on #620, I went looking for other places that will stumble, and found these.

Changes

  • Add a couple more missing std:: qualifications

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

mattw-nws
mattw-nws reviewed Aug 31, 2023
View reviewed changes
src/NGen.cpp
@@ -106,7 +106,7 @@ int main(int argc, char *argv[]) {
std::cout<<" Fortran BMI enabled"<<std::endl;
#endif
#ifdef NGEN_C_LIB_ACTIVE
cout<<" C BMI enabled"<<std::endl;
std::cout<<" C BMI enabled"<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOH... my bad.

@mattw-nws mattw-nws merged commit c317184 into NOAA-OWP:master Aug 31, 2023
19 checks passed
@PhilMiller PhilMiller deleted the fix-std branch August 31, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattw-nws mattw-nws mattw-nws left review comments

@program-- program-- program-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilMiller @program-- @mattw-nws