Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#737: SCHISM Coastal Formulation #810

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

#737: SCHISM Coastal Formulation #810

wants to merge 51 commits into from

Commits on Aug 16, 2024

  1. NOAA-OWP#737: Initial draft of Coastal Formulation interface, SCHISM … 

    …implementation, and supporting classes
    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c0294b2 View commit details
    Browse the repository at this point in the history

  2. Clean up compiler issues

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a57659f View commit details
    Browse the repository at this point in the history

  3. Another compilation fix

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4d43b38 View commit details
    Browse the repository at this point in the history

  4. More work toward Schism Formulation implementation

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    af3166f View commit details
    Browse the repository at this point in the history

  5. Reword

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d07ebf8 View commit details
    Browse the repository at this point in the history

  6. Adjust for refactor

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    17a8bfd View commit details
    Browse the repository at this point in the history

  7. Typo fix

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    28809e0 View commit details
    Browse the repository at this point in the history

  8. Parameterize SCHISM library path

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    f345e6d View commit details
    Browse the repository at this point in the history

  9. Update to match const-qualification changes

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    25209b0 View commit details
    Browse the repository at this point in the history

  10. Match added argument

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e003e76 View commit details
    Browse the repository at this point in the history

  11. Start outlining main implementation

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7478cd2 View commit details
    Browse the repository at this point in the history

  12. Finalize forcings/boundary providers

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    68dc991 View commit details
    Browse the repository at this point in the history

  13. List variables to set up before Update

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6fa3c18 View commit details
    Browse the repository at this point in the history

  14. Stylize argument-naming comment

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    04c9cf5 View commit details
    Browse the repository at this point in the history

  15. Tweak definition of all_points to clarify call site usage

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4d55b6c View commit details
    Browse the repository at this point in the history

  16. Conditionalize on Fortran support

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    67e17c8 View commit details
    Browse the repository at this point in the history

  17. Start handling input variable setup

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c366014 View commit details
    Browse the repository at this point in the history

  18. Sketch time keeping members

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    706046b View commit details
    Browse the repository at this point in the history

  19. Call BMI Init function

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1751125 View commit details
    Browse the repository at this point in the history

  20. Move input variable setup from ctor to Initialize

    @PhilMiller
    PhilMiller committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2dba565 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Match SCHISM BMI's registration/instantiaion function name

    @PhilMiller
    PhilMiller committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d687db0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Fix declaration of all_points to avoid linking errors on duplicate de… 

    …finition
    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b7d1eba View commit details
    Browse the repository at this point in the history

  2. Conditionalize SCHISM code on Fortran and MPI support

    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9b5716e View commit details
    Browse the repository at this point in the history

  3. Square away virtual method implementation

    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fa6c223 View commit details
    Browse the repository at this point in the history

  4. Typo fix in variable name

    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    56783a3 View commit details
    Browse the repository at this point in the history

  5. Bmi_Fortran_Adapter: Add MPI-specific constructor

    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    23725d1 View commit details
    Browse the repository at this point in the history

  6. SchismFormulation: Match usage to Bmi_Fortran_Adapter constructor tak… 

    …ing MPI_Comm (which calls BMI initialize)
    @PhilMiller
    PhilMiller committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d618d80 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Require MPI for the test

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c7eaf3e View commit details
    Browse the repository at this point in the history

  2. Enumerate output variables

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8b4d612 View commit details
    Browse the repository at this point in the history

  3. Implement mesh_size method

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    90b33d9 View commit details
    Browse the repository at this point in the history

  4. Implement get_values

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9d74eb2 View commit details
    Browse the repository at this point in the history

  5. Generalize output string

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b9c1237 View commit details
    Browse the repository at this point in the history

  6. Position comments better

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ffb7057 View commit details
    Browse the repository at this point in the history

  7. Square up time types

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5835aac View commit details
    Browse the repository at this point in the history

  8. Implement much of forcings

    @PhilMiller
    PhilMiller committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    686a706 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Split parallel_utils.h to header/source, and make bits usable from mu… 

    …ltiple calling objects
    @PhilMiller
    PhilMiller committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bbe5c5f View commit details
    Browse the repository at this point in the history

  2. Initialize input variables

    @PhilMiller
    PhilMiller committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b850742 View commit details
    Browse the repository at this point in the history

  3. Finalize input providers since mock is now set

    @PhilMiller
    PhilMiller committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0b0a237 View commit details
    Browse the repository at this point in the history

  4. Single-step test with mocked inputs, works for mpiexec -np 1

    @PhilMiller
    PhilMiller committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d9bcb52 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Annotate override

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b190797 View commit details
    Browse the repository at this point in the history

  2. Firm up MeshPointsSelector

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ebaa00d View commit details
    Browse the repository at this point in the history

  3. Mostly implemented NetCDF unstructured mesh reader for coastal formul… 

    …ation use
    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eaac987 View commit details
    Browse the repository at this point in the history

  4. Drop unused member variable

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    aab3cdc View commit details
    Browse the repository at this point in the history

  5. Remove unused instance and value caching from NetCDF mesh provider

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9fd9510 View commit details
    Browse the repository at this point in the history

  6. Clear out some residual cruft

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5ed7fd5 View commit details
    Browse the repository at this point in the history

  7. DataProvider: Add nicer interface to base class

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    852c31c View commit details
    Browse the repository at this point in the history

  8. NetCDF mesh data provider: fix up time keeping

    @PhilMiller
    PhilMiller committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5d2ed33 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Adjust Schism formulation and test to exploit new NetCDF mesh data pr… 

    …ovider
    @PhilMiller
    PhilMiller committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1b29181 View commit details
    Browse the repository at this point in the history

  2. Time logic cleanup

    @PhilMiller
    PhilMiller committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6a2a3dd View commit details
    Browse the repository at this point in the history

  3. SCHISM Formulation: Pass MPI communicator as constructor argument

    @PhilMiller
    PhilMiller committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b22f210 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix missing headers and conditional return in non-Python path

    @PhilMiller
    PhilMiller committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d680b07 View commit details
    Browse the repository at this point in the history