integrate Da forcing module to t-route #637
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A standalone DA forcing module was created to read observed/forecasted timseries and timeslice files for reservoir DA and streamflow nudging, perform QC, and convert them to array forms. Then the arrays are passed to t-route by BMI set_value functions. The test file, test/BMI/run_bmi_persistence_RFC_usingDAforcingModule.py, use these module for a simple test purpose. I tested with upper_routing + reservoir + lower_routing scheme and it worked. The config files are bmi_lower_example.yaml, bmi_lower_example.yaml, and bmi_reservoir_example.yaml. For RFC forecast, needed timeseries files will be prepared.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other