generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Great Lakes Data Assimilation #808
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
959c422
update creation of great lakes climatology
shorvath-noaa c8c1eec
pass great lakes DA info through to compute
shorvath-noaa 88a966b
update properties handling great lakes info
shorvath-noaa e02b44b
set default empty df for great lakes info
shorvath-noaa 595f024
preprocess great lakes DA info, create 'update_after_compute()' function
shorvath-noaa ffe1267
create new get_timeslice_obs function specific for great lakes
shorvath-noaa 53c0202
add option for great lakes DA
shorvath-noaa 5fda225
function for performing great lakes DA
shorvath-noaa 2986bcf
finalize great_lakes.update_after_compute() function
shorvath-noaa e68dd58
define after compute functions for great lakes DA
shorvath-noaa c2ac770
update _prep_reservoir_da_dataframes() to include great lakes
shorvath-noaa f650959
refine passing objects to great lakes da module
shorvath-noaa 5ae2357
finalize da function for great lakes
shorvath-noaa e617b7e
update creation of great lakes climatology
shorvath-noaa ae75cb7
pass great lakes DA info through to compute
shorvath-noaa b48f1c4
update properties handling great lakes info
shorvath-noaa 7b3476c
set default empty df for great lakes info
shorvath-noaa 960aa7a
preprocess great lakes DA info, create 'update_after_compute()' function
shorvath-noaa 2d5975a
create new get_timeslice_obs function specific for great lakes
shorvath-noaa 316edec
add option for great lakes DA
shorvath-noaa 78b0cb2
function for performing great lakes DA
shorvath-noaa 23a6ec2
finalize great_lakes.update_after_compute() function
shorvath-noaa ba667fe
define after compute functions for great lakes DA
shorvath-noaa 1cbc1d8
update _prep_reservoir_da_dataframes() to include great lakes
shorvath-noaa aac5702
refine passing objects to great lakes da module
shorvath-noaa 1e9a5b0
finalize da function for great lakes
shorvath-noaa 7e0a7b3
merge changes
shorvath-noaa c34a95a
add default empty dataframe for gl_climatology_df_sub
shorvath-noaa 14b8cf2
add column names for empty data frame gl_df_sub
shorvath-noaa 09d0129
set default empty data frames for great lakes dfs
shorvath-noaa 7e45245
move _canadian_gage_df slot from HYFeatures to AbstractNetwork
shorvath-noaa a46d407
check if list of new great_lakes_param_dfs is empty before trying to …
shorvath-noaa ecbb855
set default _canadian_gage_link_df in NHDNetwork
shorvath-noaa b4e17dc
update DA settings for test cases
shorvath-noaa 79d4888
add empty placeholders in diffusive results for great lakes DA
shorvath-noaa efd8ad7
Merge branch 'master' into great_lakes_DA
shorvath-noaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is very similar to
get_obs_from_timeslices
function. Is it possible to merge these two?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's actually identical just without the interpolation step. We could merge them, but I do want to avoid interpolating for the Great Lakes, so we'd have to alter the original function to only interpolate under certain conditions. I chose this method for now for simplicity, but I'm open to re-working this function.