Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove standard topmodel output when running from ngen #41

Merged
merged 62 commits into from
Mar 29, 2024
Merged

Remove standard topmodel output when running from ngen #41

merged 62 commits into from
Mar 29, 2024

Commits on Jul 25, 2023

  1. testing fork

    @Ben-Choat
    Ben-Choat committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    11b32be View commit details
    Browse the repository at this point in the history

  2. removing test file

    @Ben-Choat
    Ben-Choat committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bfea366 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Failed attempt at implementing calibratable params

    @Ben-Choat
    Ben-Choat committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    fe7cd9b View commit details
    Browse the repository at this point in the history

  2. backup/scratch working files to be removed later

    @Ben-Choat
    Ben-Choat committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bdc39b0 View commit details
    Browse the repository at this point in the history

  3. fixing an accidental comment included with this file

    @Ben-Choat
    Ben-Choat committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    4d40b80 View commit details
    Browse the repository at this point in the history

  4. remove nstep dt from config and set to 1 in else block initalize - fi… 

    …xing accidental comment associated w/this file
    @Ben-Choat
    Ben-Choat committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9c0745c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. refactoring init to smaller functions

    @Ben-Choat
    Ben-Choat committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    122ae65 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. refactored init() into smaller functions

    @Ben-Choat
    Ben-Choat committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e29eed6 View commit details
    Browse the repository at this point in the history

  2. refactored init() into smaller functions

    @Ben-Choat
    Ben-Choat committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d8c7221 View commit details
    Browse the repository at this point in the history

  3. refactored init() to smaller functions

    @Ben-Choat
    Ben-Choat committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bbfa55c View commit details
    Browse the repository at this point in the history

  4. refactoring init() to smaller functions - update comments

    @Ben-Choat
    Ben-Choat committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    60dbc77 View commit details
    Browse the repository at this point in the history

  5. refactored init() to smaller functions - added missing \+

    @Ben-Choat
    Ben-Choat committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    53b0419 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. removing file that was not intended to push originally, and was only … 

    …used locally
    @Ben-Choat
    Ben-Choat committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    76a8988 View commit details
    Browse the repository at this point in the history

  2. adding refactored init() function to update calibratable parameters

    @Ben-Choat
    Ben-Choat committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    840028c View commit details
    Browse the repository at this point in the history

  3. better organizing and adding comments in code

    @Ben-Choat
    Ben-Choat committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5607002 View commit details
    Browse the repository at this point in the history

  4. removing folder that was not not originally intended to push

    @Ben-Choat
    Ben-Choat committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    59ae02d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. updating commenting and including new init functions in bmi_topmodel.c

    @Ben-Choat
    Ben-Choat committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8264d68 View commit details
    Browse the repository at this point in the history

  2. edited init() prototype tp match change of order of input variables i… 

    …n topmodel.c
    @Ben-Choat
    Ben-Choat committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7756c24 View commit details
    Browse the repository at this point in the history

  3. changed order of init() input variables so outputs come last. Also up… 

    …dated comments relate dto functions
    @Ben-Choat
    Ben-Choat committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    aca60e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. imporved comments and organization

    @Ben-Choat
    Ben-Choat committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    54675ee View commit details
    Browse the repository at this point in the history

  2. Toward updating calibratable params with refactored functions

    @Ben-Choat
    Ben-Choat committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    558f90a View commit details
    Browse the repository at this point in the history

  3. added lines to include chv, rv as paramters and include the prototype… 

    …s of the new functions
    @Ben-Choat
    Ben-Choat committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7c1f590 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. updating comments for clarity

    @Ben-Choat
    Ben-Choat committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9eb924f View commit details
    Browse the repository at this point in the history

  2. actively working on using refactored init() functions to update calib… 

    …ratable parameters
    @Ben-Choat
    Ben-Choat committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9eb91bf View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. added chv & rv to model data structure. Updated order of init() proto… 

    …type input variables.
    @Ben-Choat
    Ben-Choat committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    116d98c View commit details
    Browse the repository at this point in the history

  2. updated Set_value function to incorporate calibratable parameters. St… 

    …ill testing.
    @Ben-Choat
    Ben-Choat committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    5529661 View commit details
    Browse the repository at this point in the history

  3. updated order of init() input variables. Added some print statements … 

    …for printing out updates relevant to calibratable parameters.
    @Ben-Choat
    Ben-Choat committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    609fa10 View commit details
    Browse the repository at this point in the history

  4. updated output messages related to calibratable parameters

    @Ben-Choat
    Ben-Choat committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    55298a8 View commit details
    Browse the repository at this point in the history

  5. made small edits to Set_value - removed uneeded calibratable parameters

    @Ben-Choat
    Ben-Choat committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fb822d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. updated code related to calibrated parameters in Set_value().

    @Ben-Choat
    Ben-Choat committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    14f875d View commit details
    Browse the repository at this point in the history

  2. edited order of refactored functions to be more logical. added print … 

    …statements related to calibratable parameters.
    @Ben-Choat
    Ben-Choat committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    379f352 View commit details
    Browse the repository at this point in the history

  3. added a few print lines for troubleshooting. Unexpected behavior rela… 

    …ted to tch.
    @Ben-Choat
    Ben-Choat committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8c5d597 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. removed print statements no longer needed/relevant

    @Ben-Choat
    Ben-Choat committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f6a8ca8 View commit details
    Browse the repository at this point in the history

  2. removed/edited comments no longer needed

    @Ben-Choat
    Ben-Choat committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    aca081d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. small updates to comments

    @Ben-Choat
    Ben-Choat committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1bbd41d View commit details
    Browse the repository at this point in the history

  2. updating some comments

    @Ben-Choat
    Ben-Choat committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c524a3a View commit details
    Browse the repository at this point in the history

  3. updated comments

    @Ben-Choat
    Ben-Choat committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6e58fd1 View commit details
    Browse the repository at this point in the history

  4. removed uneeded comments

    @Ben-Choat
    Ben-Choat committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1b06db4 View commit details
    Browse the repository at this point in the history

  5. corrected a typo in comments

    @Ben-Choat
    Ben-Choat committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cfbdec5 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. add helper function to shift Q array by one

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3b25e5c View commit details
    Browse the repository at this point in the history

  2. properly account for time delayed flow accumulation in Q

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    98c2a1c View commit details
    Browse the repository at this point in the history

  3. use dynamic tch array in convert_dist_to_histords

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c81f69d View commit details
    Browse the repository at this point in the history

  4. use dynamic tch array in calc_time_delay_histogram

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    00db5ea View commit details
    Browse the repository at this point in the history

  5. simplify ordinate area adjustment and validate oridnates sum to 1

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    dd56d13 View commit details
    Browse the repository at this point in the history

  6. ensure Q is dynamically initialized

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b625c15 View commit details
    Browse the repository at this point in the history

  7. Add macros for model limit warnings

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0042550 View commit details
    Browse the repository at this point in the history

  8. Remove hard coded program limits

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    da5b500 View commit details
    Browse the repository at this point in the history

  9. fix logical operator

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    92c6017 View commit details
    Browse the repository at this point in the history

  10. small combine loop optimization

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8bd02b6 View commit details
    Browse the repository at this point in the history

  11. add debug and sanitize flags to unit test build

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    625e351 View commit details
    Browse the repository at this point in the history

  12. fix bug in printing value from pointer

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fc066cb View commit details
    Browse the repository at this point in the history

  13. comment bmi Q initialization

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2ffd6e4 View commit details
    Browse the repository at this point in the history

  14. temporarly 'fix' standalone mode allocation of Q in driver

    @hellkite500
    hellkite500 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    76c3b3f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Corrected amount Q is shifted by at each timestep to include num_dela… 

    …y+num_time_delay_histo_ords, instead of just num_time_dealy_histo_ords. Also edited a print statement, and an error to provide assistance to user about how to fix error.
    @Ben-Choat
    Ben-Choat committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1978a88 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Added stand_alone to init() and init_discharge, and edited to allocat… 

    …e Q differently depending on if stand alon emode or not. Seeing discrepancies between master stand_alone results and current stand_alone results. Differences exist before these edits.
    @Ben-Choat
    Ben-Choat committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    38f3a95 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. fixed error - szq and sum_histogram_ordinates were reported incorrect… 

    …ly to output when in stand_alone mode
    @Ben-Choat
    Ben-Choat committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8c7ad8c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. cleaned up some indentation/formatting

    @Ben-Choat
    Ben-Choat committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9f3b0e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Edited so standard topmodel output files are only written when in sta… 

    …nd alone mode (i.e., stand_alone == 1)
    @Ben-Choat
    Ben-Choat committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0c346a4 View commit details
    Browse the repository at this point in the history

  2. added if statements so info about calibratable parameters is only pri… 

    …nted when in debug mode
    @Ben-Choat
    Ben-Choat committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    51959a2 View commit details
    Browse the repository at this point in the history

  3. added stand_alone as input to water balance to fix seg fault when in … 

    …stand_alone mode
    @Ben-Choat
    Ben-Choat committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    aec96a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge remote-tracking branch 'origin/master' into remove-topmodel-out… 

    …put-fromNGEN-resynced
    @Ben-Choat
    Ben-Choat committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    9330aec View commit details
    Browse the repository at this point in the history

  2. merging w/master

    @Ben-Choat
    Ben-Choat committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    7dfb805 View commit details
    Browse the repository at this point in the history