Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better error handling for database issues #33

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

epag
Copy link
Collaborator

@epag epag commented Jul 11, 2024

When we are unable to connect to a database report the reason why instead of wrapping and forgetting it. Also be more clear in the error message for failure cause and remove NPE

Changes Made

  • Fix ambiguous error message with database connection issues

Testing

  • manual testing

Related Tickets

Checklists

Deployment Plan (For developer use)

How does the changes affect the product?

  • Feature addition
  • Bug fix
  • Database change

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • The feature branch you're submitting as a PR is up to date
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • No Placeholder code
  • Reviewers requested
  • Add yourself as an assignee in the PR

Merge Checklist (For Technical Lead use only)

  • If applicable, update README with major alterations

When we are unable to connect to a database report the reason why
instead of wrapping and forgetting it. Also be more clear in the error
message for failure cause and remove NPE
@epag epag added this to the v6.25 milestone Jul 11, 2024
@epag epag self-assigned this Jul 11, 2024
@epag epag merged commit ad8302c into master Jul 11, 2024
3 checks passed
@epag epag deleted the nullDatabase branch July 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null database is attempted to be used
1 participant