Skip to content

Commit

Permalink
chore(cli): add clarifying comment (vercel#62418)
Browse files Browse the repository at this point in the history
## Changes

- Add clarifying comment around why we're `process.exit(1)` at the end
of `runLintCheck`
- Related → vercel#62378

Closes NEXT-2576
  • Loading branch information
samcx authored Feb 22, 2024
1 parent 5a4b56f commit e64dbaa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/next/src/cli/next-lint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ const nextLint: CliCommand = async (args) => {
} else if (lintResults && !lintOutput) {
printAndExit(green('✔ No ESLint warnings or errors'), 0)
} else {
// this makes sure we exit 1 after the error from line 116
// in packages/next/src/lib/eslint/runLintCheck
process.exit(1)
}
})
Expand Down

0 comments on commit e64dbaa

Please sign in to comment.