Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 스크랩 상품 등록 API 연결 #34

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

Hyobeen-Park
Copy link
Contributor

Related issue 🛠

Work Description ✏️

  • 스크랩 추가 API를 연결했습니다.

Screenshot 📸

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

흐어 스크랩도 연결 성공!! 스크랩 이미지 바뀌는 부분이 수정이 필요할 것 같긴 한데,,, 요건 추후에 수정해볼게요!!

# Conflicts:
#	app/src/main/java/org/sopt/kream/data/datasource/ProductRemoteDataSource.kt
#	app/src/main/java/org/sopt/kream/data/datasourceimpl/ProductRemoteDataSourceImpl.kt
#	app/src/main/java/org/sopt/kream/data/repository/ProductRepositoryImpl.kt
#	app/src/main/java/org/sopt/kream/data/service/ProductService.kt
#	app/src/main/java/org/sopt/kream/domain/repository/ProductRepository.kt
#	app/src/main/java/org/sopt/kream/presentation/common/ViewModelFactory.kt
#	app/src/main/res/drawable/shape_border_radius_8.xml
#	app/src/main/res/values/strings.xml
Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~ 서버 통신은 뭐 리뷰 달 게 없네용

# Conflicts:
#	app/src/main/java/org/sopt/kream/data/datasource/ProductRemoteDataSource.kt
#	app/src/main/java/org/sopt/kream/data/datasourceimpl/ProductRemoteDataSourceImpl.kt
#	app/src/main/java/org/sopt/kream/data/repository/ProductRepositoryImpl.kt
#	app/src/main/java/org/sopt/kream/data/service/ProductService.kt
#	app/src/main/java/org/sopt/kream/domain/repository/ProductRepository.kt
@Hyobeen-Park Hyobeen-Park merged commit b172172 into develop May 23, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the feat-add-scrap branch May 25, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 스크랩 상품 등록 API 연결
2 participants