-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple updated to make isempty workable for each data structures #50
Conversation
Performance Results
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 83.59% 82.60% -1.00%
==========================================
Files 14 14
Lines 1018 1029 +11
==========================================
- Hits 851 850 -1
- Misses 167 179 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
test/test_BA_ABA_matrix.jl
Outdated
for mat in [a, ba, aba] | ||
test_value = false | ||
try | ||
show(@eval a); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
show(@eval a); | |
show(@eval a) |
test/test_BA_ABA_matrix.jl
Outdated
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
end | |
end |
test/test_virtual_lodf.jl
Outdated
# test show | ||
test_value = false | ||
try | ||
show(vlodf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
show(vlodf); | |
show(vlodf) |
test/test_virtual_lodf.jl
Outdated
end | ||
end | ||
@test test_value | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
test/test_virtual_ptdf.jl
Outdated
# test show | ||
test_value = false | ||
try | ||
show(vptdf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
show(vptdf); | |
show(vptdf) |
test/test_virtual_ptdf.jl
Outdated
end | ||
end | ||
@test test_value | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
@alefcastelli can you post the error. There is no reason for PF's to be throwing an error because of show methods. |
Without theses changes, PowerFlows.jl was throwing an error related to
Base.show
. The following changes fix the issue.