Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dense method and a new MKLPardiso for LODF evaluation #59

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

alefcastelli
Copy link
Contributor

Significantly improved the Dense method for LODF, added MKLPardiso too

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Performance Results

Version Precompile Time
Main 2.796618501
This Branch 2.879219858
Version Execute Time
Main-Build PTDF First 6.091816755
Main-Build PTDF Second 0.177255791
Main-Build Ybus First 0.433796684
Main-Build Ybus Second 0.010287156
Main-Build LODF First 0.634063624
Main-Build LODF Second 0.32547704
This Branch-Build PTDF First 5.939638931
This Branch-Build PTDF Second 0.184075437
This Branch-Build Ybus First 0.437042699
This Branch-Build Ybus Second 0.010191951
This Branch-Build LODF First 0.824601463
This Branch-Build LODF Second 0.31579442

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #59 (2355d9e) into main (e5bac6a) will increase coverage by 0.24%.
The diff coverage is 90.32%.

❗ Current head 2355d9e differs from pull request most recent head 9e71bb1. Consider uploading reports for the commit 9e71bb1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   78.39%   78.64%   +0.24%     
==========================================
  Files          14       14              
  Lines        1120     1133      +13     
==========================================
+ Hits          878      891      +13     
  Misses        242      242              
Flag Coverage Δ
unittests 78.64% <90.32%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lodf_calculations.jl 96.21% <90.32%> (-0.40%) ⬇️

... and 2 files with indirect coverage changes

src/lodf_calculations.jl Outdated Show resolved Hide resolved
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the additional method that has the "for testing" comment.

test/test_lodf.jl Outdated Show resolved Hide resolved
test/test_lodf.jl Outdated Show resolved Hide resolved
test/test_BA_ABA_matrix.jl Outdated Show resolved Hide resolved
test/test_ptdf.jl Outdated Show resolved Hide resolved
test/test_virtual_ptdf.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara merged commit 6bce1d5 into main Sep 21, 2023
6 of 7 checks passed
@jd-lara jd-lara deleted the afc/BLAS_improvements_and_MKLPardiso_LODF branch October 7, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants