Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afc/radial_branches_matrices #67

Merged
merged 39 commits into from
Jan 11, 2024
Merged

afc/radial_branches_matrices #67

merged 39 commits into from
Jan 11, 2024

Conversation

alefcastelli
Copy link
Contributor

The PR adds new features regarding the possibility to evaluate all the network matrices considering a simplified system without leaf buses and radial branches.

The option reduce_radial_branches is available for all matrix types.

src/lodf_calculations.jl Outdated Show resolved Hide resolved
@alefcastelli alefcastelli reopened this Dec 22, 2023
@alefcastelli alefcastelli marked this pull request as draft December 22, 2023 18:45
Copy link
Contributor

github-actions bot commented Dec 22, 2023

Performance Results

Version Precompile Time
Main 1.061942991
This Branch 1.050490793
Version Execute Time
Main-Build PTDF First 5.140552071
Main-Build PTDF Second 0.080847141
Main-Build Ybus First 0.365427704
Main-Build Ybus Second 0.007624685
Main-Build LODF First 1.00409551
Main-Build LODF Second 0.17395954
This Branch-Build PTDF First 5.068937842
This Branch-Build PTDF Second 0.109859449
This Branch-Build Ybus First 0.360871366
This Branch-Build Ybus Second 0.006972285
This Branch-Build LODF First 1.019933353
This Branch-Build LODF Second 0.296530531

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4a055d1) 76.40% compared to head (f590cb1) 78.13%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   76.40%   78.13%   +1.73%     
==========================================
  Files          15       15              
  Lines        1280     1386     +106     
==========================================
+ Hits          978     1083     +105     
- Misses        302      303       +1     
Flag Coverage Δ
unittests 78.13% <91.44%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/BA_ABA_matrices.jl 98.07% <100.00%> (+0.25%) ⬆️
src/PowerNetworkMatrices.jl 100.00% <ø> (ø)
src/incedence_matrix.jl 85.00% <100.00%> (+8.07%) ⬆️
src/system_utils.jl 100.00% <100.00%> (ø)
src/virtual_lodf_calculations.jl 89.88% <100.00%> (+2.10%) ⬆️
src/virtual_ptdf_calculations.jl 88.76% <100.00%> (+2.24%) ⬆️
src/ptdf_calculations.jl 93.06% <97.29%> (+3.50%) ⬆️
src/common.jl 92.72% <93.54%> (-0.38%) ⬇️
src/lodf_calculations.jl 78.74% <93.75%> (+2.82%) ⬆️
src/radial_braches.jl 86.04% <77.55%> (-9.79%) ⬇️

src/common.jl Outdated Show resolved Hide resolved
src/common.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara mentioned this pull request Dec 28, 2023
@jd-lara
Copy link
Member

jd-lara commented Jan 4, 2024

@alefcastelli I made some improvements to the RadialBranches code for the integration with PowerSimulations.jl. One test for the PTDF seems to be failing but it isn't clear why. I think that the test is written in a way that the indexing doesn't work as expected.

@jd-lara jd-lara self-assigned this Jan 4, 2024
src/PowerNetworkMatrices.jl Outdated Show resolved Hide resolved
src/lodf_calculations.jl Outdated Show resolved Hide resolved
src/ptdf_calculations.jl Outdated Show resolved Hide resolved
src/BA_ABA_matrices.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara marked this pull request as ready for review January 9, 2024 18:24
src/lodf_calculations.jl Outdated Show resolved Hide resolved
src/lodf_calculations.jl Outdated Show resolved Hide resolved
src/lodf_calculations.jl Outdated Show resolved Hide resolved
src/radial_braches.jl Outdated Show resolved Hide resolved
src/radial_braches.jl Outdated Show resolved Hide resolved
test/test_lodf_with_radial_branches.jl Outdated Show resolved Hide resolved
test/test_lodf_with_radial_branches.jl Outdated Show resolved Hide resolved
test/test_lodf_with_radial_branches.jl Outdated Show resolved Hide resolved
test/test_lodf_with_radial_branches.jl Outdated Show resolved Hide resolved
test/test_lodf_with_radial_branches.jl Outdated Show resolved Hide resolved
src/ptdf_calculations.jl Outdated Show resolved Hide resolved
test/test_ptdf_with_radial_lines.jl Outdated Show resolved Hide resolved
src/incedence_matrix.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara merged commit f731e95 into main Jan 11, 2024
9 checks passed
@jd-lara jd-lara deleted the afc/radial_branches_matrices branch October 18, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants