Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max log #72

Merged
merged 1 commit into from
Jan 22, 2024
Merged

use max log #72

merged 1 commit into from
Jan 22, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 22, 2024

reduces the log print of the same message multiple times

@jd-lara jd-lara self-assigned this Jan 22, 2024
Copy link
Contributor

Performance Results

Version Precompile Time
Main 1.07413875
This Branch 1.077378599
Version Run Time
Main-Build PTDF First 5.291245748
Main-Build PTDF Second 0.111159193
Main-Build Ybus First 0.37719468
Main-Build Ybus Second 0.007241562
Main-Build LODF First 1.199075737
Main-Build LODF Second 0.17856528
This Branch-Build PTDF First 5.28926629
This Branch-Build PTDF Second 0.132774984
This Branch-Build Ybus First 0.375737878
This Branch-Build Ybus Second 0.007568785
This Branch-Build LODF First 1.14792464
This Branch-Build LODF Second 0.198527236

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51c22ce) 77.93% compared to head (65d738e) 77.93%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   77.93%   77.93%           
=======================================
  Files          15       15           
  Lines        1396     1396           
=======================================
  Hits         1088     1088           
  Misses        308      308           
Flag Coverage Δ
unittests 77.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/row_cache.jl 95.12% <100.00%> (ø)

@jd-lara jd-lara merged commit 045c479 into main Jan 22, 2024
9 checks passed
@jd-lara jd-lara deleted the jd/log_print_reduce branch January 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants