Merge pull request #202 from NREL/Fix-library-seralizer

Fix Library serralizer
NREL · Jan 27, 2023 · 9819194 · 9819194
2 parents a7659a1 + 0b51a9d
commit 9819194
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/buildingmotif/api/serializers/library.py b/buildingmotif/api/serializers/library.py
@@ -2,7 +2,7 @@
 
 from typing_extensions import TypedDict
 
-from buildingmotif.database.tables import DBLibrary
+from buildingmotif.database.tables import DBLibrary, DBTemplate
 
 LibraryDict = TypedDict(
     "LibraryDict",
@@ -43,9 +43,11 @@ def _serialize(library: DBLibrary) -> LibraryDict:
     :return: serialized library
     :rtype: LibraryDict
     """
+    templates: List[DBTemplate] = library.templates  # apleasing the type checker.
+
     return {
         "id": library.id,
         "name": library.name,
-        "template_ids": library.templates,
+        "template_ids": [t.id for t in templates],
         "shape_collection_id": library.shape_collection_id,
     }
diff --git a/tests/unit/api/test_library.py b/tests/unit/api/test_library.py
@@ -27,6 +27,7 @@ def test_get_all_libraries(client, building_motif):
 def test_get_library(client, building_motif):
     # Setup
     lib = Library.create("my_library")
+    lib.create_template("my_template")
 
     # Act
     results = client.get(f"/libraries/{lib.id}")