Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUSS VRF DOAS update #168

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

EUSS VRF DOAS update #168

wants to merge 6 commits into from

Conversation

JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented May 14, 2024

Pull request overview

this is ready for your review! @ChristopherCaradonna

  • upsizing algorithm fix

    • coming from Jeff Munk's comment summarized below:

    image

    • made changes in the VRF DOAS measure to revise the upsizing algorithm.

    • ran 10k to compare before and after this change. some comparisons are attached below and impact of this change seems minimal in terms of 10k runs:

      • aggregated energy (top = "before" based one full run, bottom = "after" based on 10k run)

      image
      image

      • savings distribution (top = "before" based one full run, bottom = "after" based on 10k run)

      image
      image

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

@JanghyunJK JanghyunJK changed the title Vrf upsizing algo fix EUSS VRF upsizing algorithm fix May 14, 2024
@JanghyunJK JanghyunJK self-assigned this May 14, 2024
@JanghyunJK JanghyunJK added the upgrade measure PR improves or adds upgrade measures label May 14, 2024
@JanghyunJK JanghyunJK changed the title EUSS VRF upsizing algorithm fix EUSS VRF DOAS update May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade measure PR improves or adds upgrade measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant